Refactor: Remove bpcg dependency on Psi and Hamilt #5643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
reviewed
Nov 29, 2024
mohanchen
approved these changes
Nov 29, 2024
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* Refactor: Remove bpcg dependency on Psi and Hamilt * Test: change bpcg tests to fit new interface * Test: make bpcg restart the same time as before in test * Tests: add the template disambiguator for dependent names for bpcg tests * Refactor: clean up bpcg * Docs: new BPCG interface * clean up bpcg code * clean useless code * clean useless code * clean useless code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
#5442
What's changed?
HamiltandPsicustom types, hindering a good testing framework.